向 Array.model 中添加自定义函数

我正在开发一个支持 AJAX 的 asp.net 应用程序。 我刚刚给 Array 原型添加了一些方法,比如

Array.prototype.doSomething = function(){
...
}

这个解决方案对我很有效,可以以一种“漂亮”的方式重用代码。

但是当我测试它与整个页面的工作,我有问题. 。 我们有一些自定义 ajax 扩展程序,它们开始表现得出乎意料: 一些控件在其内容或值周围显示“未定义”。

造成这种情况的原因是什么? 我是不是忽略了一些关于修改标准对象原型的内容?

注意: 我非常肯定,当我修改 Array 的原型时,错误就开始了。它应该只与 IE 兼容。

86761 次浏览

Modifying the built-in object prototypes is a bad idea in general, because it always has the potential to clash with code from other vendors or libraries that loads on the same page.

In the case of the Array object prototype, it is an especially bad idea, because it has the potential to interfere with any piece of code that iterates over the members of any array, for instance with for .. in.

To illustrate using an example (borrowed from here):

Array.prototype.foo = 1;


// somewhere deep in other javascript code...
var a = [1,2,3,4,5];
for (x in a){
// Now foo is a part of EVERY array and
// will show up here as a value of 'x'
}

Unfortunately, the existence of questionable code that does this has made it necessary to also avoid using plain for..in for array iteration, at least if you want maximum portability, just to guard against cases where some other nuisance code has modified the Array prototype. So you really need to do both: you should avoid plain for..in in case some n00b has modified the Array prototype, and you should avoid modifying the Array prototype so you don't mess up any code that uses plain for..in to iterate over arrays.

It would be better for you to create your own type of object constructor complete with doSomething function, rather than extending the built-in Array.

What about Object.defineProperty?

There now exists Object.defineProperty as a general way of extending object prototypes without the new properties being enumerable, though this still doesn't justify extending the built-in types, because even besides for..in there is still the potential for conflicts with other scripts. Consider someone using two Javascript frameworks that both try to extend the Array in a similar way and pick the same method name. Or, consider someone forking your code and then putting both the original and forked versions on the same page. Will the custom enhancements to the Array object still work?

This is the reality with Javascript, and why you should avoid modifying the prototypes of built-in types, even with Object.defineProperty. Define your own types with your own constructors.

In general messing with the core javascript objects is a bad idea. You never know what any third party libraries might be expecting and changing the core objects in javascript changes them for everything.

If you use Prototype it's especially bad because prototype messes with the global scope as well and it's hard to tell if you are going to collide or not. Actually modifying core parts of any language is usually a bad idea even in javascript.

(lisp might be the small exception there)

You augmented generic types so to speak. You've probably overwritten some other lib's functionality and that's why it stopped working.

Suppose that some lib you're using extends Array with function Array.remove(). After the lib has loaded, you also add remove() to Array's prototype but with your own functionality. When lib will call your function it will probably work in a different way as expected and break it's execution... That's what's happening here.

There is a caution! Maybe you did that: fiddle demo

Let us say an array and a method foo which return first element:

var myArray = ["apple","ball","cat"];


foo(myArray) // <- 'apple'


function foo(array){
return array[0]
}

The above is okay because the functions are uplifted to the top during interpretation time.

But, this DOES NOT work: (Because the prototype is not defined)

myArray.foo() // <- 'undefined function foo'


Array.prototype.foo = function(){
return this[0]
}

For this to work, simply define prototypes at the top:

Array.prototype.foo = function(){
return this[0]
}


myArray.foo() // <- 'apple'

And YES! You can override prototypes!!! It is ALLOWED. You can even define your own own add method for Arrays.

While the potential for clashing with other bits o' code the override a function on a prototype is still a risk, if you want to do this with modern versions of JavaScript, you can use the Object.defineProperty method, e.g.

// functional sort
Object.defineProperty(Array.prototype, 'sortf', {
value: function(compare) { return [].concat(this).sort(compare); }
});

Using Recursion

function forEachWithBreak(someArray, fn){
let breakFlag = false
function breakFn(){
breakFlag = true
}
function loop(indexIntoSomeArray){


if(!breakFlag && indexIntoSomeArray<someArray.length){
fn(someArray[indexIntoSomeArray],breakFn)
loop(indexIntoSomeArray+1)
}
}
loop(0)
}

Test 1 ... break is not called

forEachWithBreak(["a","b","c","d","e","f","g"], function(element, breakFn){
console.log(element)
})

Produces a b c d e f g

Test 2 ... break is called after element c

forEachWithBreak(["a","b","c","d","e","f","g"], function(element, breakFn){
console.log(element)
if(element =="c"){breakFn()}
})

Produces a b c

There are 2 problems (as mentioned above)

  1. It's enumerable (i.e. will be seen in for .. in)
  2. Potential clashes (js, yourself, third party, etc.)

To solve these 2 problems we will:

  1. Use Object.defineProperty
  2. Give a unique id for our methods
const arrayMethods = {
doSomething: "uuid() - a real function"
}


Object.defineProperty(Array.prototype, arrayMethods.doSomething, {
value() {
// Your code, log as an example
this.forEach(v => console.log(v))
}
})


const arr = [1, 2, 3]
arr[arrayMethods.doSomething]() // 1, 2, 3

The syntax is a bit weird but it's nice if you want to chain methods (just don't forget to return this):

arr
.map(x=>x+1)
[arrayMethods.log]()
.map(x=>x+1)
[arrayMethods.log]()