How do I count the letters in Llanfairpwllgwyngyllgogerychwyrndrobwllllantysiliogogogoch?

print(len('Llanfairpwllgwyngyllgogerychwyrndrobwllllantysiliogogogoch'))

Says 58

Well if it was that easy I wouldn't be asking you, now would I?!

Wikipedia says (https://en.wikipedia.org/wiki/Llanfairpwllgwyngyll#Placename_and_toponymy)

The long form of the name is the longest place name in the United Kingdom and one of the longest in the world at 58 characters (51 "letters" since "ch" and "ll" are digraphs, and are treated as single letters in the Welsh language).

So I want to count that and get the answer 51.

Okey dokey.

print(len(['Ll','a','n','f','a','i','r','p','w','ll','g','w','y','n','g','y','ll','g','o','g','e','r','y','ch','w','y','r','n','d','r','o','b','w','ll','ll','a','n','t','y','s','i','l','i','o','g','o','g','o','g','o','ch']))
51

Yeh but that's cheating, obviously I want to use the word as input, not the list.

Wikipedia also says that the digraphs in Welsh are ch, dd, ff, ng, ll, ph, rh, th

https://en.wikipedia.org/wiki/Welsh_orthography#Digraphs

So off we go. Let's add up the length and then take off the double counting.

word='Llanfairpwllgwyngyllgogerychwyrndrobwllllantysiliogogogoch'
count=len(word)
print('starting with count of',count)
for index in range(len(word)-1):
substring=word[index]+word[index+1]
if substring.lower() in ['ch','dd','ff','ng','ll','ph','rh','th']:
print('taking off double counting of',substring)
count=count-1
print(count)

This gets me this far

starting with count of 58
taking off double counting of Ll
taking off double counting of ll
taking off double counting of ng
taking off double counting of ll
taking off double counting of ch
taking off double counting of ll
taking off double counting of ll
taking off double counting of ll
taking off double counting of ch
49

It appears that I've subtracted too many then. I'm supposed to get 51. Now one problem is that with the llll it has found 3 lls and taken off three instead of two. So that's going to need to be fixed. (Must not overlap.)

And then there's another problem. The ng. Wikipedia didn't say anything about there being a letter "ng" in the name, but it's listed as one of the digraphs on the page I quoted above.

Wikipedia gives us some more clue here: "additional information may be needed to distinguish a genuine digraph from a juxtaposition of letters". And it gives the example of "llongyfarch" where the ng is just a "juxtaposition of letters", and "llong" where it is a digraph.

So it seems that 'Llanfairpwllgwyngyllgogerychwyrndrobwllllantysiliogogogoch' is one of those words where the -ng- is bit just a "juxtaposition of letters".

And obviously there's no way that the computer can know that. So I'm going to have to give it that "additional information" that Wikipedia talks about.

So anyways, I decided to look in an online dictionary http://geiriadur.ac.uk/gpc/gpc.html and you can see that if you look up llongyfarch (the example from Wikipedia that has the "juxtaposition of letters") it displays it with a vertical line between the n and the g but if you look up "llong" then it doesn't do this.

screenshot from dictionary (llongyfarch)

screenshot from dictionary (llong)

So I've decided okay what we need to do is provide the additional information by putting a | in the input string like it does in the dictionary, just so that the algorithm knows that the ng bit is really two letters. But obviously I don't want the | itself to be counted as a letter.

So now I've got these inputs:

word='llong'
ANSWER NEEDS TO BE 3 (ll o ng)


word='llon|gyfarch'
ANSWER NEEDS TO BE 9 (ll o n g y f a r ch)


word='Llanfairpwllgwyn|gyllgogerychwyrndrobwllllantysiliogogogoch'
ANSWER NEEDS TO BE 51 (Ll a n f a i r p w ll g w y n g y ll g o g e r y ch w y r n d r o b w ll ll a n t y s i l i o g o g o g o ch)

and still this list of digraphs:

['ch','dd','ff','ng','ll','ph','rh','th']

and the rules are going to be:

ignore case
if you see a digraph then count it as 1
work from left to right so that llll is ll + ll, not l + ll + l
if you see a | don't count it, but you can't ignore it completely, it is there to stop ng being a digraph

and I want it to count it as 51 and to do it for the right reasons, not just fluke it.

Now I am getting 51 but it is fluking it because it is counting the | as a letter (1 too high), and then it is taking off one too many with the llll (1 too low) - ERRORS CANCEL OUT

It is getting llong right (3).

It is getting llon|gyfarch wrong (10) - counting the | again

How can I fix it the right way?

2212

小开

Step through the string letter by letter
If you are at index n and and s[n:n+2] is a digraph, add or increment a dictionary with the digraph as the key, and increment the index by 1 as well so you don't start on the second digraph character. If it's not a digraph, just add or increment the letter to the dict and go to the next letter.
If you see the | character, don't count it, just skip.
And don't forget to lowercase.

When you've seen all the letters, the loop ends and you add all the counts in the dict.

Here's my code, it works on your three examples:

from collections import defaultdict


digraphs=['ch','dd','ff','ng','ll','ph','rh','th']
breakchars=['|']




def welshcount(word):
word = word.lower()
index = 0
counts = defaultdict(int)  # keys start at 0 if not already present
while index < len(word):
if word[index:index+2] in digraphs:
counts[word[index:index+2]] += 1
index += 1
elif word[index] in breakchars:
pass  # in case you want to do something here later
else:  # plain old letter
counts[word[index]] += 1


index += 1


return sum(counts.values())


word1='llong'
#ANSWER NEEDS TO BE 3 (ll o ng)


word2='llon|gyfarch'
#ANSWER NEEDS TO BE 9 (ll o n g y f a r ch)


word3='Llanfairpwllgwyn|gyllgogerychwyrndrobwllllantysiliogogogoch'
#ANSWER NEEDS TO BE 51 (Ll a n f a i r p w ll g w y n g y ll g o g e r y ch w y r n d r o b w ll ll a n t y s i l i o g o g o g o ch)


print(welshcount(word1))
print(welshcount(word2))
print(welshcount(word3))

小开

You can get the length by replacing all the double letters with a . (or any other character, ? would do just fine), and measuring the length of the resulting string (subtracting the amount of |):

def get_length(name):
name = name.lower()
doubles = ['ch', 'dd', 'ff', 'ng', 'll', 'ph', 'rh', 'th']
for double in doubles:
name = name.replace(double, '.')
return len(name) - name.count('|')


name = 'Llanfairpwllgwyn|gyllgogerychwyrndrobwllllantysiliogogogoch'
print(get_length(name))
>>> 51

小开

最佳答案

Like many problems to do with strings, this can be done in a simple way with a regex.

>>> word = 'Llanfairpwllgwyn|gyllgogerychwyrndrobwllllantysiliogogogoch'
>>> import re
>>> pattern = re.compile(r'ch|dd|ff|ng|ll|ph|rh|th|[^\W\d_]', flags=re.IGNORECASE)
>>> len(pattern.findall(word))
51

The character class [^\W\d_] (from here) matches word-characters that are not digits or underscores, i.e. letters, including those with diacritics.

小开

You could use a Combining Grapheme Joiner (+u034F) character to join the letters and then take your character count and take away the number of these joiners * 2.

http://www.comisiynyddygymraeg.cymru/English/Part%203/10%20Locales%20alphabets%20and%20character%20sets/10.2%20Alphabets/Pages/10-2-4-Combining-Grapheme-Joiner.aspx

The Welsh Language Commissioner also addresses the issue here: http://www.comisiynyddygymraeg.cymru/English/Part%203/10%20Locales%20alphabets%20and%20character%20sets/10.2%20Alphabets/Pages/10-2-1-Character-vs--letter-counts.aspx